<html>
<head><meta charset="utf-8"><title>1.52 regressions · t-release · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/index.html">t-release</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html">1.52 regressions</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="236857001"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236857001" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236857001">(Apr 30 2021 at 15:48)</a>:</h4>
<p>wanted to kick this off to start a few checks / enumerate pending work</p>



<a name="236857058"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236857058" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236857058">(Apr 30 2021 at 15:49)</a>:</h4>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/84667">https://github.com/rust-lang/rust/issues/84667</a> will be fixed by - <a href="https://github.com/rust-lang/rust/pull/84710">https://github.com/rust-lang/rust/pull/84710</a> needs to land, but looks blocked on some sort of coverage test failure? Not clear what's going on, cc <span class="user-mention" data-user-id="116083">@pnkfelix</span> -- do you expect to patch that and re-approve?</li>
</ul>



<a name="236857096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236857096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236857096">(Apr 30 2021 at 15:49)</a>:</h4>
<ul>
<li>c-unwind backport landed in <a href="https://github.com/rust-lang/rust/pull/84722">https://github.com/rust-lang/rust/pull/84722</a>, so good there</li>
</ul>



<a name="236857213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236857213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236857213">(Apr 30 2021 at 15:50)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E52.20regressions/near/236857058">said</a>:</p>
<blockquote>
<ul>
<li><a href="https://github.com/rust-lang/rust/pull/84710">https://github.com/rust-lang/rust/pull/84710</a> needs to land, but looks blocked on some sort of coverage test failure? Not clear what's going on, cc <span class="user-mention silent" data-user-id="116083">pnkfelix</span> -- do you expect to patch that and re-approve?</li>
</ul>
</blockquote>
<p>thanks for the heads up. I’ll try to look into that.</p>



<a name="236857310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236857310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236857310">(Apr 30 2021 at 15:50)</a>:</h4>
<p>(I want to make more progress on revert of PR <a href="https://github.com/rust-lang/rust/issues/80653">#80653</a> for issue <a href="https://github.com/rust-lang/rust/issues/82465">#82465</a> first though.)</p>



<a name="236857560"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236857560" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236857560">(Apr 30 2021 at 15:52)</a>:</h4>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/84139">#84139</a> and <a href="https://github.com/rust-lang/rust/issues/84136">#84136</a> are being closed as won't fix looks like, so we'll want to include them in compat notes. I've left a <a href="https://github.com/rust-lang/rust/pull/84183/files#r623985089">comment</a> there; cc <span class="user-mention" data-user-id="219696">@XAMPPRocky</span></li>
</ul>



<a name="236857833"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236857833" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236857833">(Apr 30 2021 at 15:55)</a>:</h4>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/82913">#82913</a> we are expecting to fix with a removal of assert_matches! - it looks like libs wanted it removed from the prelude <em>only</em>, but to avoid bikeshed on where to put it instead I'm inclined to just drop it from this stable release cc <span class="user-mention" data-user-id="310399">@Mara</span> on that 'decision'. I can try to post a PR here shortly, targeting beta directly; we'll want a more proper fix on master.</li>
</ul>



<a name="236858608"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236858608" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236858608">(Apr 30 2021 at 16:00)</a>:</h4>
<p>I think that should be the main ones, going off of <a href="https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.52.0">https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.52.0</a></p>
<p>cc <span class="user-mention" data-user-id="121055">@Pietro Albini</span></p>



<a name="236858646"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236858646" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236858646">(Apr 30 2021 at 16:00)</a>:</h4>
<p>maybe some beta backports in flight as well, not sue</p>



<a name="236860151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236860151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236860151">(Apr 30 2021 at 16:10)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E52.20regressions/near/236857833">said</a>:</p>
<blockquote>
<ul>
<li><a href="https://github.com/rust-lang/rust/issues/82913">#82913</a> we are expecting to fix with a removal of assert_matches! - it looks like libs wanted it removed from the prelude <em>only</em>, but to avoid bikeshed on where to put it instead I'm inclined to just drop it from this stable release cc <span class="user-mention silent" data-user-id="310399">Mara</span> on that 'decision'. I can try to post a PR here shortly, targeting beta directly; we'll want a more proper fix on master.</li>
</ul>
</blockquote>
<p>sorry for dropping the ball on that one. i'll send a PR to remove it from beta. not clear what the right fix would be on master though. moving it to the 2021 prelude should only happen with a proper migration lint, which we don't have for something like this.</p>



<a name="236860367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236860367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236860367">(Apr 30 2021 at 16:11)</a>:</h4>
<p><span class="user-mention" data-user-id="310399">@Mara</span> oh, I'm already preparing that PR</p>



<a name="236860429"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236860429" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236860429">(Apr 30 2021 at 16:12)</a>:</h4>
<p>oh okay, go ahead. didn't start yet. thanks :)</p>



<a name="236860618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236860618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236860618">(Apr 30 2021 at 16:13)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E52.20regressions/near/236858608">said</a>:</p>
<blockquote>
<p>I think that should be the main ones, going off of <a href="https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.52.0">https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.52.0</a></p>
<p>cc <span class="user-mention silent" data-user-id="121055">Pietro Albini</span></p>
</blockquote>
<p>will take a look in a bit, and go through <code>regressions-from-stable-to-beta</code></p>



<a name="236860633"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236860633" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236860633">(Apr 30 2021 at 16:13)</a>:</h4>
<p><span class="user-mention" data-user-id="310399">@Mara</span> would appreciate a review of <a href="https://github.com/rust-lang/rust/pull/84759">https://github.com/rust-lang/rust/pull/84759</a></p>



<a name="236860639"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236860639" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236860639">(Apr 30 2021 at 16:13)</a>:</h4>
<p>Thanks pietro!</p>



<a name="236866934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236866934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236866934">(Apr 30 2021 at 16:57)</a>:</h4>
<ul>
<li><strong>Invalid field is never read: lint warning</strong> <a href="https://github.com/rust-lang/rust/issues/81658">#81658</a> -- would love more insights from <span class="user-mention" data-user-id="116083">@pnkfelix</span>, my understanding is that this was a 1.51 regression "fixed" on 1.51 beta by reverting the cause, we assumed we would properly fix it by 1.52 but we actually did not, is that correct?</li>
</ul>



<a name="236873747"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236873747" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236873747">(Apr 30 2021 at 17:40)</a>:</h4>
<ul>
<li><strong> ICE when reifying function pointers to copy / copy_nonoverlapping using an if</strong> <a href="https://github.com/rust-lang/rust/issues/84297">#84297</a> -- has a fix landed on master, need to backport it to beta, nominating it</li>
</ul>



<a name="236880637"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236880637" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tm <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236880637">(Apr 30 2021 at 18:27)</a>:</h4>
<p>I would also suggest backporting <a href="https://github.com/rust-lang/rust/issues/83401">#83401</a>, which fixes a bug that was reported a number of times already. The patch itself is relatively self-contained.</p>



<a name="236881113"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236881113" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236881113">(Apr 30 2021 at 18:30)</a>:</h4>
<p>nominated it</p>



<a name="236881204"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236881204" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tm <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236881204">(Apr 30 2021 at 18:31)</a>:</h4>
<p>Thanks.</p>



<a name="236883169"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236883169" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236883169">(Apr 30 2021 at 18:45)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121055">Pietro Albini</span> <a href="#narrow/stream/241545-t-release/topic/1.2E52.20regressions/near/236866934">said</a>:</p>
<blockquote>
<ul>
<li><strong>Invalid field is never read: lint warning</strong> <a href="https://github.com/rust-lang/rust/issues/81658">#81658</a> -- would love more insights from <span class="user-mention silent" data-user-id="116083">pnkfelix</span>, my understanding is that this was a 1.51 regression "fixed" on 1.51 beta by reverting the cause, we assumed we would properly fix it by 1.52 but we actually did not, is that correct?</li>
</ul>
</blockquote>
<p>hmm let me look</p>



<a name="236883355"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236883355" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236883355">(Apr 30 2021 at 18:46)</a>:</h4>
<p>oh jeez, Im sorry, I didn’t realize that <a href="https://github.com/rust-lang/rust/issues/83004">#83004</a> never actually landed.</p>



<a name="236883491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236883491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236883491">(Apr 30 2021 at 18:47)</a>:</h4>
<p>I think we should revert <a href="https://github.com/rust-lang/rust/issues/81473">#81473</a> on 1.52 beta, just as we did for 1.51</p>



<a name="236883706"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236883706" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tm <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236883706">(Apr 30 2021 at 18:49)</a>:</h4>
<p>I think beta already has the fix for <a href="https://github.com/rust-lang/rust/issues/81626">#81626</a> (and the other issue <a href="https://github.com/rust-lang/rust/issues/81658">#81658</a> wasn't considered sufficient for revert on its own).</p>



<a name="236883924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236883924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tm <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236883924">(Apr 30 2021 at 18:50)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> ^^</p>



<a name="236883964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236883964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236883964">(Apr 30 2021 at 18:51)</a>:</h4>
<p>let me look again</p>



<a name="236884001"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236884001" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236884001">(Apr 30 2021 at 18:51)</a>:</h4>
<ul>
<li><strong>Internal Compiler Error: 'attempt to subtract with overflow', compiler/rustc_session/src/session.rs:478:22</strong> <a href="https://github.com/rust-lang/rust/issues/84219">#84219</a> -- error=&gt;ICE when the compiler is built with custom flags, not worth rushing a fix IMO</li>
</ul>



<a name="236884125"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236884125" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236884125">(Apr 30 2021 at 18:52)</a>:</h4>
<p>ok <span class="user-mention" data-user-id="116122">@simulacrum</span> went through the regressions-from-stable-to-beta</p>



<a name="236885349"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236885349" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236885349">(Apr 30 2021 at 19:01)</a>:</h4>
<p>my gut is that we should still revert <a href="https://github.com/rust-lang/rust/issues/81473">#81473</a></p>



<a name="236885511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236885511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236885511">(Apr 30 2021 at 19:02)</a>:</h4>
<p>Did I screw up in yesterday’s triage meeting? were these issues discussed there...</p>



<a name="236885695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/236885695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#236885695">(Apr 30 2021 at 19:03)</a>:</h4>
<p>oh its P-medium, that’s probably why we didn’t discuss it yesterday...</p>



<a name="237002263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237002263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237002263">(May 01 2021 at 21:28)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="#narrow/stream/241545-t-release/topic/1.2E52.20regressions/near/236885695">said</a>:</p>
<blockquote>
<p>oh its P-medium, that’s probably why we didn’t discuss it yesterday...</p>
</blockquote>
<p>yes, <a href="#narrow/stream/245100-t-compiler.2Fwg-prioritization.2Falerts/topic/.2384219.20Internal.20Compiler.20Error.3A.20'attempt.20to.20subtract.20with.20o.E2.80.A6">we assigned</a> a P-medium and went unnoticed. If it's the case let's raise to P-high (at this point more for the records)</p>



<a name="237152750"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237152750" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237152750">(May 03 2021 at 12:25)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> fyi I didn't get around to some of the backports finalizing over the weekend, so we'll want to bundle them in the promotion probably</p>



<a name="237152797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237152797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237152797">(May 03 2021 at 12:25)</a>:</h4>
<p>Notably the revert of assert matches at least</p>



<a name="237152806"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237152806" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237152806">(May 03 2021 at 12:25)</a>:</h4>
<p>I'll take a look first thing today</p>



<a name="237156437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237156437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237156437">(May 03 2021 at 12:58)</a>:</h4>
<p>ok, going to try to summarize state and then get into it</p>



<a name="237156523"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237156523" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237156523">(May 03 2021 at 12:59)</a>:</h4>
<ul>
<li>[beta] revert PR <a href="https://github.com/rust-lang/rust/issues/77885">#77885</a> <a href="https://github.com/rust-lang/rust/issues/84710">#84710</a></li>
<li>[beta] remove assert_matches <a href="https://github.com/rust-lang/rust/issues/84759">#84759</a> </li>
<li>Update RELEASES.md for 1.52.0 <a href="https://github.com/rust-lang/rust/issues/84183">#84183</a></li>
</ul>



<a name="237156663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237156663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237156663">(May 03 2021 at 13:00)</a>:</h4>
<p>Release notes aren't yet ready - some final edits left in comments on that, <span class="user-mention" data-user-id="219696">@XAMPPRocky</span> do you expect to have time to finish those up in the next few hours? If not, I (or Pietro) can likely take that on.</p>



<a name="237156714"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237156714" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237156714">(May 03 2021 at 13:00)</a>:</h4>
<p>Oh yep, I can take care of that.</p>



<a name="237156743"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237156743" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237156743">(May 03 2021 at 13:00)</a>:</h4>
<p>Thanks!</p>



<a name="237156867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237156867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237156867">(May 03 2021 at 13:01)</a>:</h4>
<p>It looks like both beta revert PRs are hitting some coverage test failure, which is annoying... I'll see if I can fix it on one and then we can apply the same patch</p>



<a name="237157895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237157895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237157895">(May 03 2021 at 13:09)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Have a look, should be good to go now.</p>



<a name="237158089"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237158089" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237158089">(May 03 2021 at 13:10)</a>:</h4>
<p>left two comments, would be great to squash to ease cherry-picking it, and r=me</p>



<a name="237158444"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237158444" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237158444">(May 03 2021 at 13:13)</a>:</h4>
<p>Hm. The coverage tests are passing as-is for me locally, I guess it might be dependent on the channel? Let me check that...</p>



<a name="237158889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237158889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237158889">(May 03 2021 at 13:17)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> ^ on the release note comments</p>



<a name="237159069"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237159069" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> hyd-dev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237159069">(May 03 2021 at 13:18)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E52.20regressions/near/237158444">said</a>:</p>
<blockquote>
<p>Hm. The coverage tests are passing as-is for me locally, I guess it might be dependent on the channel? Let me check that...</p>
</blockquote>
<p>It could be <a href="https://github.com/rust-lang/rust/issues/83262">#83262</a>.</p>



<a name="237159251"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237159251" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237159251">(May 03 2021 at 13:20)</a>:</h4>
<p>Yeah, sounds like the exact same failure. I'm going to drop the commit I just pushed and just retry the PR then</p>



<a name="237159404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237159404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237159404">(May 03 2021 at 13:22)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> actually to avoid wasting too much ci time, I think we should just bundle the 3 PRs into the promotion, would you be up for posting that?</p>



<a name="237159497"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237159497" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237159497">(May 03 2021 at 13:22)</a>:</h4>
<p>specifically cherry pick release notes <a href="https://github.com/rust-lang/rust/pull/84183">https://github.com/rust-lang/rust/pull/84183</a>, and <a href="https://github.com/rust-lang/rust/pull/84710">https://github.com/rust-lang/rust/pull/84710</a> as well as <a href="https://github.com/rust-lang/rust/pull/84759">https://github.com/rust-lang/rust/pull/84759</a></p>



<a name="237159513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237159513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237159513">(May 03 2021 at 13:22)</a>:</h4>
<p>I can in roughly an hour, if you can do it sooner please do</p>



<a name="237159530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237159530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237159530">(May 03 2021 at 13:22)</a>:</h4>
<p>hmm</p>



<a name="237159534"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237159534" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237159534">(May 03 2021 at 13:22)</a>:</h4>
<p>ok I'll run promotion</p>



<a name="237159723"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237159723" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237159723">(May 03 2021 at 13:24)</a>:</h4>
<p>ok, promoted beta to stable and will bundle things into my existing beta-next PR</p>



<a name="237159773"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237159773" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237159773">(May 03 2021 at 13:24)</a>:</h4>
<p>or actually I guess I'll open a new one since it's targeting stable</p>



<a name="237160082"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237160082" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237160082">(May 03 2021 at 13:27)</a>:</h4>
<p>making changes to release notes manually</p>



<a name="237160913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237160913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237160913">(May 03 2021 at 13:33)</a>:</h4>
<p>alright, r+'d and yielded the current PR</p>



<a name="237160948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237160948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237160948">(May 03 2021 at 13:33)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Updated and squashed.</p>



<a name="237163680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237163680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237163680">(May 03 2021 at 13:53)</a>:</h4>
<p>Hmmm</p>



<a name="237163720"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237163720" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237163720">(May 03 2021 at 13:53)</a>:</h4>
<p>Closed tree, going to retry another time, but possibly some issue with the apple builders</p>



<a name="237200973"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237200973" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237200973">(May 03 2021 at 17:52)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> fyi just r+'d <a href="https://github.com/rust-lang/rust/pull/84864">https://github.com/rust-lang/rust/pull/84864</a>, hopefully that'll go through without too much hassle</p>



<a name="237201024"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237201024" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237201024">(May 03 2021 at 17:53)</a>:</h4>
<p><span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span> still didn't finish handling some <a href="http://crates.io">crates.io</a> stuff, unfortunately that's taking a while</p>



<a name="237205501"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237205501" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237205501">(May 03 2021 at 18:20)</a>:</h4>
<p>Oh, gah. I had forgotten about some of the beta-nominated PRs I think</p>



<a name="237205504"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237205504" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237205504">(May 03 2021 at 18:20)</a>:</h4>
<p>doing that now</p>



<a name="237205677"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237205677" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237205677">(May 03 2021 at 18:22)</a>:</h4>
<p>this is going to be a mess in terms of making sure we land the needed stuff on 1.53 and 1.54 too</p>



<a name="237216140"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216140" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216140">(May 03 2021 at 19:34)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> oh did you start the build already?</p>



<a name="237216165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216165">(May 03 2021 at 19:34)</a>:</h4>
<p>I've been fixing ci for the last several hours</p>



<a name="237216172"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216172" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216172">(May 03 2021 at 19:34)</a>:</h4>
<p>well, off and on as it fails</p>



<a name="237216194"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216194" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216194">(May 03 2021 at 19:34)</a>:</h4>
<p>gah</p>



<a name="237216201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216201">(May 03 2021 at 19:34)</a>:</h4>
<p>I think I added all the relevant backports</p>



<a name="237216235"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216235" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216235">(May 03 2021 at 19:35)</a>:</h4>
<p>and it seems to be going for longer than last time, so I'm hopeful</p>



<a name="237216272"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216272" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216272">(May 03 2021 at 19:35)</a>:</h4>
<p>note to self: do a triage on t-release side earlier next cycle</p>



<a name="237216336"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216336" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216336">(May 03 2021 at 19:35)</a>:</h4>
<p>hey, if you want to kickoff the 1.53 promotion (i.e. beta) and figure out the set intersection of backports that'll need seems good :)</p>



<a name="237216367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216367">(May 03 2021 at 19:36)</a>:</h4>
<p>alternative is tomorrow, I guess</p>



<a name="237216421"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216421" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216421">(May 03 2021 at 19:36)</a>:</h4>
<p>don't we need a bootstrap compiler for beta?</p>



<a name="237216446"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216446" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216446">(May 03 2021 at 19:36)</a>:</h4>
<p>I guess I can do the backports</p>



<a name="237216451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216451">(May 03 2021 at 19:36)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  are we still missing the stack-probing change on beta? who is doing that?</p>



<a name="237216459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216459">(May 03 2021 at 19:36)</a>:</h4>
<p>sure, I just mean, like, there's some legwork to do to figure out what needs to get put onto it regardles</p>



<a name="237216599"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216599" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216599">(May 03 2021 at 19:37)</a>:</h4>
<p><span class="user-mention" data-user-id="138448">@cuviper</span> I think we reverted again, in <a href="https://github.com/rust-lang/rust/pull/84710">https://github.com/rust-lang/rust/pull/84710</a> (which is included in the current stable-targeted rollup)</p>



<a name="237216823"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237216823" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237216823">(May 03 2021 at 19:39)</a>:</h4>
<p>oh I missed the new rollup, ok</p>



<a name="237217157"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237217157" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237217157">(May 03 2021 at 19:41)</a>:</h4>
<p>(I was only looking at the current state of the branches)</p>



<a name="237220374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237220374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237220374">(May 03 2021 at 20:04)</a>:</h4>
<p>I think <span class="user-mention" data-user-id="116122">@simulacrum</span> said they’d put up a PR. Let me check.</p>



<a name="237220382"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237220382" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237220382">(May 03 2021 at 20:04)</a>:</h4>
<p>yeah it's all good</p>



<a name="237220390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237220390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237220390">(May 03 2021 at 20:04)</a>:</h4>
<p>you put up the PR?</p>



<a name="237220435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237220435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237220435">(May 03 2021 at 20:05)</a>:</h4>
<p>yeah, sorry for the unnecessary ping</p>



<a name="237220445"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237220445" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237220445">(May 03 2021 at 20:05)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E52.20regressions/near/237220390">said</a>:</p>
<blockquote>
<p>you put up the PR?</p>
</blockquote>
<p>was this directed at me?</p>



<a name="237220450"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237220450" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237220450">(May 03 2021 at 20:05)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> <a href="https://github.com/rust-lang/rust/pull/84710">https://github.com/rust-lang/rust/pull/84710</a> is the thing, right?</p>



<a name="237220480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237220480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237220480">(May 03 2021 at 20:05)</a>:</h4>
<p>that’s hat I think <span class="user-mention" data-user-id="138448">@cuviper</span> is asking about, yeah</p>



<a name="237220494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237220494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237220494">(May 03 2021 at 20:05)</a>:</h4>
<p>ok, yeah, that's included in the rollup, so we should be good</p>



<a name="237222028"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237222028" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237222028">(May 03 2021 at 20:16)</a>:</h4>
<p>ok, we're testing and I've treeclosed to avoid spurious failures needing a 'foreign' retry vs just a local one</p>



<a name="237225188"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20regressions/near/237225188" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20regressions.html#237225188">(May 03 2021 at 20:38)</a>:</h4>
<p>ended up spending more time than planned on <a href="http://crates.io">crates.io</a> (deployed an index that should hopefully improve availability), will do the beta thing tomorrow morning</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>